Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )
Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... PS2, Line 70: register "generic.stop_delay_ms" = "100"
Do we need the stop pin for SiS? And if yes, what pin of SiS will be connected since I don't see thi […]
Do we want to wait the new datasheet from SiS? b/152936541#comment20
https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... PS4, Line 68: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
It seems SiS does not support stop/report GPIO. No need to configure stop_gpio in that case. […]
Do we want to wait the new datasheet from SiS? b/152936541#comment20