Attention is currently required from: Subrata Banik. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61499 )
Change subject: mb/google/brya: Lock TPM pin in brask and brya baseboards ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/variants/agah/gpio.c:
https://review.coreboot.org/c/coreboot/+/61499/comment/9c27b747_9313517a PS5, Line 37: /* B7 : ISH_12C1_SDA ==> PCH_I2C_TPM_SDA */ : PAD_CFG_NF_LOCK(GPP_B7, NONE, NF2, LOCK_CONFIG), : /* B8 : ISH_I2C1_SCL ==> PCH_I2C_TPM_SCL */ : PAD_CFG_NF_LOCK(GPP_B8, NONE, NF2, LOCK_CONFIG), These are already defined this way in variants/baseboard/brya/gpio.c, no need to duplicate here.
Same holds true for the other files in this CL that add this configuration for GPP_B7 and GPP_B8, since all of the devices so far are brya variants (as opposed to brask variants).