Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36548 )
Change subject: drivers/intel/fsp2_0: Use strip_quotes for cbfs filenames
......................................................................
Patch Set 5:
This patch breaks our Apollo Lake based mainboards as FSP-M never returns once it is called.
If I have a closer look into the build log, I can see that the -b option for FSP-M is missing on the cbfs-add line:
CBFS fspm.bin
build/util/cbfstool/cbfstool build/coreboot.pre.tmp add -f fsp_m.fd -n fspm.bin -t fsp -r COREBOOT
If I revert this patch, everything boots fine again. The cbfs-add line looks as expexted in this case:
CBFS fspm.bin
build/util/cbfstool/cbfstool build/coreboot.pre.tmp add -f fsp_m.fd -n "fspm.bin" -t fsp -r COREBOOT -b 0xfef40000
Wim, which platform have you tested this patch on? Do I have to change anything in my .config or how is your build able to survive this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14267502cfab5308d3874a0c0fd18a71b08bb9f8
Gerrit-Change-Number: 36548
Gerrit-PatchSet: 5
Gerrit-Owner: Wim Vervoorn
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Wim Vervoorn
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 06 Nov 2019 08:12:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment