Attention is currently required from: Kedar J. Karanje, Maulik V Vaghela, vagdevi.p@intel.com, Tim Wawrzynczak, Subrata Banik, Vinay Kumar, Patrick Rudolph.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55706 )
Change subject: soc/intel/alderlake: Set max Pkg C-states to Auto
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55706/comment/490156f1_db26ae00
PS5, Line 9: This patch configures max Pkg C-state t0 Auto which
nit: to
Done
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55706/comment/d2091fcd_c4b90c80
PS5, Line 339: s_cfg->PkgCStateLimit = 0xff;
can you please create a enum so its easy to understand what this 0xff
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab92eaadad3f17ed8dddc4f383d6eeaab8c9ea6e
Gerrit-Change-Number: 55706
Gerrit-PatchSet: 5
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: vagdevi.p@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: vagdevi.p@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 01 Jul 2021 11:53:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment