30 Sep
2020
30 Sep
'20
10:21 a.m.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45811 )
Change subject: mb/google/kukui: Support SKU from camera EEPROM ......................................................................
Patch Set 1:
(1 comment)
LGTM if you can fix the build failure.
https://review.coreboot.org/c/coreboot/+/45811/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/45811/1/src/mainboard/google/kukui/... PS1, Line 13: vendorcode/google/chromeos/camera.h did you forget to upload the patch for this file?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45811
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63a2b952b8c35c0ead8200d7c926e8d90a9f3fb8
Gerrit-Change-Number: 45811
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Sep 2020 08:21:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment