27 Nov
2019
27 Nov
'19
3:57 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37274 )
Change subject: superio/nct5539d: include the missing acpi.h and ssdt.h ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37274/1/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/superio.c:
https://review.coreboot.org/c/coreboot/+/37274/1/src/superio/nuvoton/nct5539... PS1, Line 27: #include <superio/common/ssdt.h> : #include <arch/acpi.h> Looks like ACPI stuffs in this file are guarded: #if CONFIG(HAVE_ACPI_TABLES)
Maybe guard the includes as well? Not sure if it matters tbh.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37274
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd80fae1c39f3c7c4bc66a42e9023fb7a727b024
Gerrit-Change-Number: 37274
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Nov 2019 14:57:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment