Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39341 )
Change subject: soc/intel/tigerlake: Set dynamic pad termination for SD CMD pin ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39341/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/39341/2/src/soc/intel/tigerlake/fsp... PS2, Line 146: dev->enabled There is a bug here - dev is not setup with the PCH_DEVFN_SDCARD. So it is checking the enabled flag of whatever device that was previously resolved i.e. IGD here.
https://review.coreboot.org/c/coreboot/+/39341/2/src/soc/intel/tigerlake/fsp... PS2, Line 153: params->SdCardGpioCmdPadTermination = DYNAMIC_PAD_TERMINATION;
I don't see why this would be required. […]
Also the UPD comment/documentation does not mention what 0x1F means. It includes until 0x19. Can you please check that? So is default UPD value messing with the NATIVE configuration?