Attention is currently required from: Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Michal Motyl, Patrick Rudolph, David Guckian.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36607 )
Change subject: mb/teleplatforms/D4E4S16P8: Configure ast25xx bootstraps
......................................................................
Patch Set 18: Verified+1
(3 comments)
File src/mainboard/teleplatforms/D4E4S16P8/ast25xx.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145320):
https://review.coreboot.org/c/coreboot/+/36607/comment/48c9a656_de96e973
PS18, Line 44: printk(BIOS_INFO, "ast25xx: disable protection status: @ 0x%p 0x%08x\n", scu_protection, locks);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145320):
https://review.coreboot.org/c/coreboot/+/36607/comment/506db757_c7e4921f
PS18, Line 47: printk(BIOS_INFO, "ast25xx: scu70_hwtrap current bits: @ 0x%p 0x%08x\n", scu_hwtrap, straps);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145320):
https://review.coreboot.org/c/coreboot/+/36607/comment/696d665a_bd1e8f6c
PS18, Line 76: printk(BIOS_INFO, "ast25xx: p2p_bridge0: 0x%x; p2p_bridge1: 0x%x\n", p2p_bridge0, p2p_bridge1);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36607
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92195969419f9c38845cb67f294fdab33fb481af
Gerrit-Change-Number: 36607
Gerrit-PatchSet: 18
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Dmitry Ponamorev
dponamorev@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: David Guckian
d.guckian20@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: David Guckian
d.guckian20@gmail.com
Gerrit-Comment-Date: Mon, 04 Apr 2022 06:10:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment