Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46509 )
Change subject: mrc_cache: Add config MRC_SAVE_HASH_IN_TPM ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... PS2, Line 55: n I agree that this has nothing to do with Chrome OS only. The suggestion was to ensure that we do not change the behavior for any of the boards without the owners deciding/understanding this. Yes, it is a good thing to have for all boards. At minimum, I think we should send out a PSA on the mailing list to ensure that the community knows that this change is coming.
Like you said it currently only affects TPM2 devices which are all Chrome OS right now, so we're not immediately affecting anyone else anyway.
That is not really true? I see the following boards using TPM2: ``` git grep "MAINBOARD_HAS_TPM2" src/mainboard/ | grep -v google src/mainboard/clevo/cml-u/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/facebook/fbg1701/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/facebook/monolith/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/intel/galileo/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/intel/jasperlake_rvp/Kconfig: select VBOOT_MOCK_SECDATA if !MAINBOARD_HAS_TPM2 src/mainboard/ocp/deltalake/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/prodrive/hermes/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/razer/blade_stealth_kbl/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/siemens/mc_apl1/variants/mc_apl5/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/siemens/mc_apl1/variants/mc_apl6/Kconfig: select MAINBOARD_HAS_TPM2 src/mainboard/system76/lemp9/Kconfig: select MAINBOARD_HAS_TPM2 ```