Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45534 )
Change subject: nb/intel/haswell: Only hide PEG devices if ONBOARD_VGA_IS_PRIMARY
......................................................................
Patch Set 5:
Patch Set 5: Code-Review-1
ONBOARD_VGA_IS_PRIMARY is meant literally. It's about onboard
chips, no matter if integrated somewhere or a discrete one. So
it can also be on PEG. There is no Kconfig yet for integrated
vs. discrete, AFAIK. That area needs to be cleaned up before
we can further build on it.
The only Haswell mainboard in the tree for which this is true is the Supermicro X10SLM-F, and the IGD is disabled on that one. I'll just add a new Kconfig option.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45534
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d825b1c41d8705bfafe28d8ecb0a511788901f0
Gerrit-Change-Number: 45534
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Oct 2020 09:46:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment