Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )
Change subject: mb/google/zork: Update SPD table for Shuboz
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v...
PS1, Line 10: 0
Why are IDs being assigned here? This is not required for new boards. You should let the tool assign the ID.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050
Gerrit-Change-Number: 47902
Gerrit-PatchSet: 1
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 24 Nov 2020 23:40:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment