[coreboot-gerrit] Change in coreboot[master]: soc/{apl,glk}: set GPU based on CONFIG_ONBOARD_VGA_IS_PRIMARY

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )

Change subject: soc/{apl,glk}: set GPU based on CONFIG_ONBOARD_VGA_IS_PRIMARY
......................................................................

Patch Set 22:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39374/17/src/soc/intel/apollolake/c... 
File src/soc/intel/apollolake/chip.h:

https://review.coreboot.org/c/coreboot/+/39374/17/src/soc/intel/apollolake/c... 
PS17, Line 45: PRIMARY_AUTO = 0,
             : 	PRIMARY_IGD  = 2,
             : 	PRIMARY_PCI  = 3,
> Unfortunately I'm unable to load the image when this parameter is set to 0:  […]

Ack

https://review.coreboot.org/c/coreboot/+/39374/7/src/soc/intel/apollolake/ro... 
File src/soc/intel/apollolake/romstage.c:

https://review.coreboot.org/c/coreboot/+/39374/7/src/soc/intel/apollolake/ro... 
PS7, Line 259: PrimaryVideoAdaptor
> For Skylake AUTO is equivalent to IDG. I don't think that in our case intel did differently. […]

Ack