Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34345 )
Change subject: include/spi-generic: moving common flash timeouts
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34345/3/src/include/spi-generic.h
File src/include/spi-generic.h:
https://review.coreboot.org/c/coreboot/+/34345/3/src/include/spi-generic.h@2...
PS3, Line 26: #define SPI_FLASH_SECTOR_ERASE_TIMEOUT (10 * CONF_SYS_HZ)
Hz is a unit. Specifically, it is 1/second (the inverse of a second). […]
Yes, we stumbled over this _HZ naming already.
I guess we should change the defines into something like ..._TIMEOUT_MS and drop the define for CONF_SYS_HZ 100 completely. It seems not to be used elsewhere anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I837f1a027b836996bc42389bdf7dbab7f0e9db09
Gerrit-Change-Number: 34345
Gerrit-PatchSet: 3
Gerrit-Owner: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 17 Jul 2019 04:45:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment