Attention is currently required from: Bob Moragues, Nick Vaccaro, Paul Menzel, Sumeet R Pawnikar, Tarun Tuli, Zhuohao Lee.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76769?usp=email )
Change subject: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76769/comment/47b0174c_b3c476ae : PS3, Line 7: brask
This should be brya, isn't it?
The baseboard of kuldax is brask, so it should be brask. Thanks.
https://review.coreboot.org/c/coreboot/+/76769/comment/92da92d1_3fd8e63f : PS3, Line 10: RPL SKUs
Only the 15 Watts variants, or are these the only ones?
Kuldax will use 15W RPL CPU. Thanks.
File src/mainboard/google/brya/variants/kuldax/ramstage.c:
https://review.coreboot.org/c/coreboot/+/76769/comment/306b527b_40e609f7 : PS3, Line 19: 100000
Add comment for this PL4 value suggested by thermal team which is different from the reference docum […]
Done.
https://review.coreboot.org/c/coreboot/+/76769/comment/317dd3bb_f811f18f : PS3, Line 43: { PCI_DID_INTEL_RPL_P_ID_5, 15, 138 }, : { PCI_DID_INTEL_RPL_P_ID_4, 15, 138 }, : { PCI_DID_INTEL_RPL_P_ID_3, 15, 138 },
I'm not clear why are we maintaining two separate structures to update the same values. […]
Celeron and Pentium have the same CPU ID (PCI_DID_INTEL_ADL_P_ID_10 --> 0x4619), Celeron will use 65W adaptor and Pentium will use 150W adaptor, so we need to create two thermal tables based on fw_config. Thanks.