Attention is currently required from: Cliff Huang, Martin Roth, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55259 )
Change subject: util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries
......................................................................
Patch Set 13:
(2 comments)
File util/cbfstool/fpt_formats/fpt_hdr_20.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129910):
https://review.coreboot.org/c/coreboot/+/55259/comment/bf26cf31_db09509d
PS13, Line 46: for (size_t i = 0; i < sizeof(*h); i++) {
braces {} are not necessary for single statement blocks
File util/cbfstool/fpt_formats/fpt_hdr_21.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129910):
https://review.coreboot.org/c/coreboot/+/55259/comment/34460c19_7d287807
PS13, Line 89: for (size_t i = 0; i < ARRAY_SIZE(h->reserved); i++) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93c8d33e9baa327cbdab918a14f2f7a039953be6
Gerrit-Change-Number: 55259
Gerrit-PatchSet: 13
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Andrew McRae
amcrae@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Andrew McRae
amcrae@google.com
Gerrit-Comment-Date: Wed, 06 Oct 2021 18:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment