Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31766 )
Change subject: Documentation: Explain FMAP and FMD ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31766/3/Documentation/lib/flashmap.md File Documentation/lib/flashmap.md:
https://review.coreboot.org/#/c/31766/3/Documentation/lib/flashmap.md@14 PS3, Line 14: to make everything that : has strict layout requirements (e.g. must be aligned to erase blocks or : something else) should be Sorry, I think you copied the grammar mistakes out of my comment. ;)
https://review.coreboot.org/#/c/31766/3/Documentation/lib/flashmap.md@20 PS3, Line 20: strcut typo
https://review.coreboot.org/#/c/31766/3/Documentation/lib/flashmap.md@45 PS3, Line 45: programmed (or after some security policy is enabled). Can we clarify that these first three are deprecated and (should) currently not (be) used by anyone? I'm honestly not sure what they were originally used for, if anything, but they don't seem to make sense in modern coreboot context. "COMPRESSED" is a single flag that doesn't tell you anything about the compression algorithm, so even if we wanted direct FMAP compression it would seem pointless. "RO" is usually better handled with nested sections since I don't think(?) we have any write-protection mechanism that can cover more than one region. And I don't really understand what "STATIC" was supposed to be in the first place.