[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add unmask eint event for bootblock

[Yidi Lin (Code Review)]

Attention is currently required from: Chhao Chang, Jarried Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )

Change subject: soc/mediatek/mt8196: Add unmask eint event for bootblock
......................................................................

Patch Set 17:

(3 comments)

File src/soc/mediatek/common/eint_event.c:

https://review.coreboot.org/c/coreboot/+/84025/comment/83ca7638_9f844b6e?usp... :
PS17, Line 15: uintptr_t reg;
> If you change it like this, my offset (i<<2) still needs to be placed in this for loop.

What is your concern ?

https://review.coreboot.org/c/coreboot/+/84025/comment/ac32ad71_b9b1a6ed?usp... :
PS17, Line 8: #define EVENT_CLEAN_MASK_OFFSET	0x880
            : #define EVENT_MASK_OFFSET	0x800
            : #define EINT_VALUE		0xFFFFFFFF
            : 
            : void enable_eint_event(uintptr_t base, unsigned int port)
            : {
            : 	unsigned int i;
            : 	uintptr_t reg;
            : 
            : 	for (i = 0; i < port; i++) {
            : 		reg = base + EVENT_CLEAN_MASK_OFFSET + (i << 2);
            : 		write32((uint32_t *)reg, EINT_VALUE);
            : 	}
            : }
> It's currently in this file

It is not necessary to define a unused `EINT_BASE` for mt8196.

File src/soc/mediatek/common/include/soc/eint_event.h:

https://review.coreboot.org/c/coreboot/+/84025/comment/883f6afa_39bc52aa?usp... :
PS17, Line 17: struct eint_info {
             : 	uintptr_t base;
             : 	unsigned int eint_num;
             : };
> eint_event.h is a common file. What is the significance of moving this structure to common. […]

Only MT8196 needs this struct.