Attention is currently required from: Raul Rangel, Patrick Rudolph, Mariusz Szafrański, Jonathan Zhang, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Tim Wawrzynczak, Christian Walter, Suresh Bellampalli, Michal Motyl, Tim Chu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39331 )
Change subject: src/*: Make PCI ID macro names shorter ......................................................................
Patch Set 8:
(10 comments)
File src/include/device/pci_ids.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/08ca0b00_d475b74b PS8, Line 150: #define PCI_DID_COMPAQ_TRIFLEX_IDE 0xae33 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/4ff8018e_3590b0be PS8, Line 1863: #define PCI_DID_CBOARDS_DAS1602_16 0x0001 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/659b14da_adcd6bca PS8, Line 1945: #define PCI_DID_APPLICOM_PCIGENERIC 0x0001 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/48579d44_a85cbe61 PS8, Line 1947: #define PCI_DID_APPLICOM_PCI2000PFB 0x0003 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/c8fb01ed_36f8f887 PS8, Line 2097: #define PCI_VID_AKS 0x416c 'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/e302c94d_afec166e PS8, Line 2098: #define PCI_DID_AKS_ALADDINCARD 0x0100 'AKS' may be misspelled - perhaps 'ASK'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/8efe9445_f4ac6b25 PS8, Line 2099: #define PCI_DID_AKS_CPC 0x0200 'AKS' may be misspelled - perhaps 'ASK'?
File src/soc/intel/skylake/vr_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/3297b751_8676279c PS8, Line 215: (igd_id == PCI_DID_INTEL_KBL_GT3E_SULTM_2)) { code indent should use tabs where possible
File src/southbridge/amd/agesa/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/c9bc0f1b_10968985 PS8, Line 66: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) { else should follow close brace '}'
File src/southbridge/amd/pi/hudson/hudson.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133938): https://review.coreboot.org/c/coreboot/+/39331/comment/192ec1e6_7e597bbc PS8, Line 41: else if (sd_device_id == PCI_DID_AMD_YANGTZE_SD) { else should follow close brace '}'