24 Apr
2020
24 Apr
'20
5:19 p.m.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39893 )
Change subject: Documentation: Add proposal for firmware unit testing ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
I would +2 but I want other reviewers' feedback before we consider this ready to merge.
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... File Documentation/technotes/2020-03-unit-testing-coreboot.md:
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 254: ├── build
Makes sense.
* exists I said "source code exits" but I meant to type "source code exists" /facepalm
--
To view, visit https://review.coreboot.org/c/coreboot/+/39893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I552d6c3373219978b8e5fd4304f993d920425431
Gerrit-Change-Number: 39893
Gerrit-PatchSet: 4
Gerrit-Owner: Name of user not set #1002873
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Jett Rink jettrink@google.com
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Kevin Shelton kmshelton@google.com
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Philip Chen philipchen@google.com
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-CC: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 24 Apr 2020 15:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Fagerburg pfagerburg@chromium.org
Comment-In-Reply-To: Name of user not set #1002873
Gerrit-MessageType: comment