[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/rex/var/rex: Configure PL4 to 64W if battery status is invalid

[Caveh Jalali (Code Review)]

Attention is currently required from: Brandon Breitenstein, Eran Mitrani, Hannah Williams, Jamie Ryu, Kapil Porwal, Sukumar Ghorai, Tarun.

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78322?usp=email )

Change subject: mb/google/rex/var/rex: Configure PL4 to 64W if battery status is invalid
......................................................................

Patch Set 5:

(1 comment)

File src/mainboard/google/rex/variants/baseboard/rex/ramstage.c:

https://review.coreboot.org/c/coreboot/+/78322/comment/b2be3dd2_9b15ce87 :
PS5, Line 48: battery_status
this is not a good test.

there are multiple bits here that would suggest using the LP profile:
EC_BATT_FLAG_LEVEL_CRITICAL
EC_BATT_FLAG_INVALID_DATA
EC_BATT_FLAG_CUT_OFF

please add a helper function that decodes these and returns a simple
value that suggests which profile to use.

also, the status bits are specific to the EC API so using them should
ideally be limited to the chromeec subsystem.