[coreboot-gerrit] Change in coreboot[master]: UPSTREAM: mb/google/volteer/variants/delbin: Update DPTF parameters f...

[Deepika Punyamurtula (Code Review)]

Deepika Punyamurtula has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46676 )

Change subject: UPSTREAM: mb/google/volteer/variants/delbin: Update DPTF parameters for delbin
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/delbin/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... 
PS4, Line 63: 15000
Yes, this looks like a typo. These need to be different. A couple of more comments 1)for the pl2 since it is different from the default 60W, the register "power_limits_config[POWER_LIMITS_U_4_CORE]" = "{ 
.tdp_pl2_override = 60,}" needs to be added. 2) Can you also add the tcc_offset="8" as it is different from the default of 10C? Thanks