Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30847 )
Change subject: mb/emulation/qemu-440fx: remove mm file listing ......................................................................
Patch Set 3:
(2 comments)
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30847/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/#/c/30847/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 29: //static FWCfgFiles *fw_files;
please don't comment code, remove it
Done
https://review.coreboot.org/#/c/30847/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 66: fw_cfg_read(&count, sizeof(count));
you could use a static buffer on heap instead of malloc. […]
We don't know if there more files in future and without a static buffer it should work then out of the box