Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45229 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssh-f board as a variant ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/45229/4/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md:
https://review.coreboot.org/c/coreboot/+/45229/4/Documentation/mainboard/sup... PS4, Line 39: Currentlt Currently, ...
https://review.coreboot.org/c/coreboot/+/45229/4/Documentation/mainboard/sup... PS4, Line 39: failed to be initialize fails to be initialized
https://review.coreboot.org/c/coreboot/+/45229/4/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45229/4/src/mainboard/supermicro/x1... PS4, Line 14: # Additional FSP Configuration : # This board has an IGD with no output. : register "PrimaryDisplay" = "Display_Auto" : what for? there is no display (connector)
https://review.coreboot.org/c/coreboot/+/45229/4/src/mainboard/supermicro/x1... PS4, Line 18: # PCIe configuration : # Enable i210-AT (GbE) : register "PcieRpEnable[0]" = "1" : register "PcieRpEnable[1]" = "1" : : # Enable M.2 : register "PcieRpEnable[4]" = "1" : : # Enable ASpeed PCI bridge : register "PcieRpEnable[6]" = "1" : : # Enable JPCIE1 : register "PcieRpEnable[8]" = "1" : move these down to the devicetree, please