Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42899 )
Change subject: sc7180: Add support for sn65dsi86 bridge.
......................................................................
Patch Set 7:
Patch Set 4:
(21 comments)
Can’t the coreboot EDID helpers be used?
Not sure what you mean, this is already calling decode_edid(). Is there any other common code it should be using? (The whole "read EDID over I2C" thing has a bunch of common code that would be nice to factor out at some point, e.g. a couple of lines here are straight out copied from the ps8640 driver. But I'm not sure it's fair to tie that work onto this CL.)
Ah, my bad. I thought there was already common code for that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36a68f3241f0ba316c261a73c2f6d30fe6c3ccdc
Gerrit-Change-Number: 42899
Gerrit-PatchSet: 7
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 21 Jul 2020 06:19:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment