Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38715 )
Change subject: mb/google/volteer: use new Tiger Lake memory config
......................................................................
Patch Set 17:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38715/16//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38715/16//COMMIT_MSG@11
PS16, Line 11: tigerlake
Tiger Lake
Done
https://review.coreboot.org/c/coreboot/+/38715/16//COMMIT_MSG@16
PS16, Line 16: log into kernel
What do you mean?
Did that help / do you understand what it means now?
https://review.coreboot.org/c/coreboot/+/38715/16/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/38715/16/src/mainboard/google/volte...
PS16, Line 27: __weak
Function declaration doesn't need __weak. It is only required in the baseboard definition.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32c9b8a040728d44565806eece6cf60b6b6073b6
Gerrit-Change-Number: 38715
Gerrit-PatchSet: 17
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 10 Feb 2020 17:17:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment