Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )
Change subject: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig
......................................................................
Patch Set 11:
Patch Set 11: Code-Review-1
I still do not see an argument in the commit message, why this is intel/icelake specific.
If such a Kconfig option is introduced, it needs to be integrated into the existing options under `src/device`, where VGA_ROM_RUN and friends are.
HI Paul, if you look at gerrit discussion, Patrick had point that keeping such kconfig into common driver might increase overhead of maintenance hence he suggested to make it soc specific. So far we don't see any such soc/rvp going to use this feature. If we think going forward that we are keeping for all rvp/soc then we should move this code into common/driver. Do you agree ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33738
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ebde69e38defbe3321eb5e5bbd632c209ae2cd8
Gerrit-Change-Number: 33738
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 22 Jul 2019 14:27:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment