Martin Roth has posted comments on this change. ( https://review.coreboot.org/27033 )
Change subject: x86 smm: Increase SMM stack size to 2K ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27033/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/27033/2//COMMIT_MSG@7 PS2, Line 7: x86 smm: Increase SMM stack size to 2K : : GSMI Set Event Log is taking more than 1K in stack. This causes the : stack to overflow into the adjacent stack. This has the side effect of : causing any CPU waiting for the SMI handler to complete to crash when : the lock is unlocked because the return pointer has been smashed. : : BUG=b:80539294 : TEST=built on grunt and tested by running `halt` from the OS. Probably want to update this now:
cpu/x86: Make SMM stack size configurable