Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45399 )
Change subject: soc/mediatek/mt8192: add pmic MT6359P driver ......................................................................
Patch Set 2:
(10 comments)
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... File src/soc/mediatek/mt8192/mt6359p.c:
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 1: /* : * This file is part of the coreboot project. : * : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
SPDX
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 21: static
static const
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 182: static
static const
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 330: 1
0x1 or 0x01 for consistency?
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 345: size_t
int
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 353: size_t
int
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 392: /* assert(0); */
keep assert, or remove this.
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 424: assert(0);
Use die()? […]
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 441: 0x%x
%#x
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 441: 0x%x
%#x
Done