Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37787 )
Change subject: security/vboot: Add a dedicated flag for building of vboot library
......................................................................
Patch Set 8:
Patch Set 8: Code-Review+2
But how to match and replace "VBOOT" without touching "*_VBOOT_*"?
Bill, probably the easiest way is to use a few different patterns.
For example:
s/CONFIG(VBOOT)/CONFIG(VBOOT_VERIFY_FIRMWARE)/
s/config VBOOT/config VBOOT_VERIFY_FIRMWARE/
But anyways, if you want to leave it as VBOOT, I guess that's fine too.
The first one (with parenthesis boundaries) should be fine, but the second one may affect "config VBOOT_*", e.g. modify "config VBOOT_LIB" into "config VBOOT_VERIFY_FIRMWARE_LIB".
The second case needs an regexp matching "VBOOT" in "VBOOT$", "VBOOT," (in Makefile.inc), "VBOOT ", but not "VBOOT_*".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1907a11c851ee45a70582e02bdbe08fb18cc6a4
Gerrit-Change-Number: 37787
Gerrit-PatchSet: 8
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Dec 2019 05:44:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment