22 Jun
2021
22 Jun
'21
5:31 p.m.
Attention is currently required from: Raul Rangel, Furquan Shaikh, Tim Wawrzynczak, Karthik Ramasubramanian, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55731 )
Change subject: Asm code: Use NO_EARLY_BOOTBLOCK_POSTCODES to remove Asm port80s ......................................................................
Patch Set 1:
(1 comment)
File src/include/cpu/x86/post_code.h:
https://review.coreboot.org/c/coreboot/+/55731/comment/b9656af5_76ac7a69 PS1, Line 7: post_code(value)
Should we also apply the new condition only if the bootflow is in bootblock? I am not sure if this i […]
Sure, I'll add that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55731
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb4a96820d5c391fc17a0f0dcccd519d4881b78c
Gerrit-Change-Number: 55731
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 22 Jun 2021 15:31:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment