build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29421 )
Change subject: mediatek/mt8183: Add PMIC wrapper support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/29421/5/src/soc/mediatek/mt8183/pmic_wrap.c
File src/soc/mediatek/mt8183/pmic_wrap.c:
https://review.coreboot.org/#/c/29421/5/src/soc/mediatek/mt8183/pmic_wrap.c@...
PS5, Line 22: #define PRIORITY_SEL_2(name, id, priority) \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/29421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbdb15f11227ded3f5d18fe6504c8c646973b733
Gerrit-Change-Number: 29421
Gerrit-PatchSet: 5
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Chun-ta Lin
itspeter@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Nov 2018 10:23:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No