Attention is currently required from: Angel Pons, Arthur Heymans, Evgeny Zinoviev, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49992 )
Change subject: sb/intel/bd82x6x/me_smm.c: Deduplicate finalisation code
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/southbridge/intel/bd82x6x/me_smm.c:
https://review.coreboot.org/c/coreboot/+/49992/comment/36889a08_7ed0bd36
PS5, Line 88: switch (did) {
Could also be moved inside mkhi_end_of_post()? There's only a single
line that differs, AFAICS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia44eb29d3509eb4208ba2aed9e0cf7e8f8d2c41a
Gerrit-Change-Number: 49992
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 11 Feb 2021 23:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment