Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82409?usp=email )
Change subject: spd_bin.h: Use same macro for DDR3 and LPDDR3 ......................................................................
spd_bin.h: Use same macro for DDR3 and LPDDR3
DDR3 and LPDDR3 share the same PART_NUM and PART_LEN. So use the same macro. This is to prepare SPD de-duplication in following patch.
Change-Id: Iea824a847b5072b1cbaa38dc38deae1d484d5b16 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/82409 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com --- M src/include/spd_bin.h 1 file changed, 5 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/include/spd_bin.h b/src/include/spd_bin.h index d0cdefc..c51e449 100644 --- a/src/include/spd_bin.h +++ b/src/include/spd_bin.h @@ -3,6 +3,7 @@ #ifndef SPD_BIN_H #define SPD_BIN_H
+#include <device/dram/ddr3.h> #include <stdint.h> #include <commonlib/region.h>
@@ -27,11 +28,11 @@ #define DDR3_BUS_DEV_WIDTH 8 #define DDR4_ORGANIZATION 12 #define DDR4_BUS_DEV_WIDTH 13 -#define DDR3_SPD_PART_OFF 128 -#define DDR3_SPD_PART_LEN 18 +#define DDR3_SPD_PART_OFF SPD_DDR3_PART_NUM +#define DDR3_SPD_PART_LEN SPD_DDR3_PART_LEN #define DDR3_SPD_SN_OFF 122 -#define LPDDR3_SPD_PART_OFF 128 -#define LPDDR3_SPD_PART_LEN 18 +#define LPDDR3_SPD_PART_OFF SPD_DDR3_PART_NUM +#define LPDDR3_SPD_PART_LEN SPD_DDR3_PART_LEN #define DDR4_SPD_PART_OFF 329 #define DDR4_SPD_PART_LEN 20 #define DDR4_SPD_SN_OFF 325