Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43175 )
Change subject: mb/google/dedede/var/boten: Update devicetree ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43175/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43175/5/src/mainboard/google/dedede... PS5, Line 12: #| I2C1 | Digitizer | You can remove it, if Boten doesn't use I2C1.
https://review.coreboot.org/c/coreboot/+/43175/5/src/mainboard/google/dedede... PS5, Line 14: #| I2C3 | Camera | You can remove it, if Boten doesn't use I2C3.
https://review.coreboot.org/c/coreboot/+/43175/5/src/mainboard/google/dedede... PS5, Line 25: .i2c[1] = { : .speed = I2C_SPEED_FAST, : }, You can remove it, if Boten doesn't use I2C1.
https://review.coreboot.org/c/coreboot/+/43175/5/src/mainboard/google/dedede... PS5, Line 31: .i2c[3] = { : .speed = I2C_SPEED_FAST, : }, You can remove it, if Boten doesn't use I2C3.