Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43790 )
Change subject: mb/google/volteer: Update flashmap descriptor for CSE Lite FW update
......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43790/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43790/1//COMMIT_MSG@7
PS1, Line 7: mb/google/volteer: fmd update for CSE Lite Firmware Update
Please make it a statement by using a verb (in imperative mood): […]
Done
https://review.coreboot.org/c/coreboot/+/43790/1//COMMIT_MSG@8
PS1, Line 8:
Please add a problem description in the beginning.
Done
https://review.coreboot.org/c/coreboot/+/43790/1//COMMIT_MSG@9
PS1, Line 9: Updated
Present tense: Update
Done
https://review.coreboot.org/c/coreboot/+/43790/1//COMMIT_MSG@9
PS1, Line 9: fmd
flash map descriptor?
Thanks! I updated the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3c2b657f0426d206dfe3729829ec34ff57812c7
Gerrit-Change-Number: 43790
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 24 Jul 2020 09:02:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment