Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46700 )
Change subject: soc/intel/broadwell: Separate PCH in devicetree ......................................................................
Patch Set 9: Code-Review-2
Breaks booting on out-of-tree board:
CPU PL1 = 1542 Watts CPU PL2 = 1542 Watts CPU Index 0 - APIC 0 Unexpected Exception:13 @ 10:78f8607e - Halting Code: 0 eflags: 00010002 cr2: 00000000 eax: 00ddb030 ebx: 0000065c ecx: 0000065c edx: 0001b030 edi: 0001b030 esi: 78fb7000 ebp: 000007d0 esp: 78fc1ed0
0x78f86038: ff 7f 00 00 81 cf 00 80 0x78f86040: 01 00 50 68 80 c7 fa 78 0x78f86048: 6a 06 e8 69 d0 01 00 89 0x78f86050: fa b9 10 06 00 00 89 e8 0x78f86058: 0f 30 0f b7 6e 04 81 cb 0x78f86060: 00 00 01 00 83 c4 10 89 0x78f86068: 1d a0 59 d1 fe 89 3d a4 0x78f86070: 59 d1 fe 85 ed 74 38 bb 0x78f86078: 5c 06 00 00 89 d9 0f 32 0x78f86080: 51 89 c7 55 68 94 c7 fa 0x78f86088: 78 6a 06 e8 28 d0 01 00 0x78f86090: 8a 4c 24 10 89 f8 0f b7 0x78f86098: 56 04 d3 e2 89 d9 81 e2 0x78f860a0: ff 7f 00 00 81 ca 00 80 0x78f860a8: 01 00 0f 30 83 c4 10 0f 0x78f860b0: b7 7e 06 85 ff 74 55 bb 0x78fc1f4c: 0x78f9bf90 0x78fc1f48: 0x78fb6e44 0x78fc1f44: 0x78fb8320 0x78fc1f40: 0x00000075 0x78fc1f3c: 0x0002affc 0x78fc1f38: 0x0002affc 0x78fc1f34: 0x0002affc 0x78fc1f30: 0x00000075 0x78fc1f2c: 0x78fa2fbc 0x78fc1f28: 0x78fc8c20 0x78fc1f24: 0x78fb1c1e 0x78fc1f20: 0x78fb8320 0x78fc1f1c: 0x78f9bf27 0x78fc1f18: 0x78fc1fd8 0x78fc1f14: 0x00000005 0x78fc1f10: 0x78fb6e44 0x78fc1f0c: 0x78fb8320 0x78fc1f08: 0x78fb8320 0x78fc1f04: 0x78fb7000 0x78fc1f00: 0x0000001c 0x78fc1efc: 0x78f8c40f 0x78fc1ef8: 0x78fc1fd8 0x78fc1ef4: 0x00000005 0x78fc1ef0: 0x78fb6e44 0x78fc1eec: 0x78fb8320 0x78fc1ee8: 0x00000000 0x78fc1ee4: 0x00000000 0x78fc1ee0: 0x78fb6e40 0x78fc1edc: 0x00000000 0x78fc1ed8: 0x00000000 0x78fc1ed4: 0x00000008 0x78fc1ed0: 0x00000003 <-esp