Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31423 )
Change subject: SMBIOS: Add new MEMORY_{TYPE,TECHNOLOGY,OPERATING} macros
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31423/3/src/include/smbios.h
File src/include/smbios.h:
https://review.coreboot.org/#/c/31423/3/src/include/smbios.h@95
PS3, Line 95:
should I add a comment here? for exmple : […]
No, whoever use this will have the spec and know what it is. It just caught me off guard.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e466614d0a9e8c89f298594a5785af775b22a95
Gerrit-Change-Number: 31423
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Feb 2019 20:39:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment