Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34687 )
Change subject: soc/intel/cometlake: Add ISH Device ID ......................................................................
soc/intel/cometlake: Add ISH Device ID
This Device ID is specific to CML, since it is obtained by reading ISH configuration RO register. In order to export ISH to kernel PCI device tree, this number must be included in list of devices supported.
Change-Id: I6d245f1b3f0d0cfec77c31033eb20f147fd3d870 Signed-off-by: Bernardo Perez Priego bernardo.perez.priego@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34687 Reviewed-by: Li1 Feng li1.feng@intel.com Reviewed-by: Mathew King mathewk@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/ish/ish.c M src/include/device/pci_ids.h 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Li1 Feng: Looks good to me, but someone else must approve Mathew King: Looks good to me, approved
diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c index bc1b6fa..f506a7c 100644 --- a/src/drivers/intel/ish/ish.c +++ b/src/drivers/intel/ish/ish.c @@ -66,6 +66,7 @@
static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_INTEL_CNL_ISHB, + PCI_DEVICE_ID_INTEL_CML_ISHB, 0 };
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 3ac6560..2501640 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2102,6 +2102,7 @@ #define PCI_DEVICE_ID_INTEL_82437VX 0x7030 #define PCI_DEVICE_ID_INTEL_82439TX 0x7100 #define PCI_DEVICE_ID_INTEL_CNL_ISHB 0x9dfc +#define PCI_DEVICE_ID_INTEL_CML_ISHB 0x02fc
/* Intel 82371FB (PIIX) */ #define PCI_DEVICE_ID_INTEL_82371FB_ISA 0x122e