[coreboot-gerrit] Change in coreboot[master]: {northbridge,soc,southbridge}: Don't use both of _ADR and _HID

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36318 )

Change subject: {northbridge,soc,southbridge}: Don't use both of _ADR and _HID
......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36318/13/src/northbridge/amd/agesa/... 
File src/northbridge/amd/agesa/family14/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/36318/13/src/northbridge/amd/agesa/... 
PS13, Line 21: Name(_ADR, 0x00180000)	/* Dev# = BSP Dev#, Func# = 0 */
This looks like the address of a device on the bus not like the bus.

https://review.coreboot.org/c/coreboot/+/36318/13/src/soc/intel/broadwell/ac... 
File src/soc/intel/broadwell/acpi/serialio.asl:

https://review.coreboot.org/c/coreboot/+/36318/13/src/soc/intel/broadwell/ac... 
PS13, Line 208: 	Name (_ADR, 0x00150001)
This (and all the other serial i/o PCI devices) should depend on
`sio_acpi_mode` (see `chip.h`), afaict.