Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42242 )
Change subject: drivers/ocp/ipmi: Add ipmi set processor information
......................................................................
Patch Set 9:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/42242/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42242/9//COMMIT_MSG@7
PS9, Line 7: drivers/ocp/ipmi: Add ipmi set processor information
Because there are other ocp functions such as dmi(CB:40308), maybe drivers/ocp/ipmi is better?
no. drivers/ipmi/ocp is better. The first level directory under drivers is better to be technology (eg. ipmi).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42242
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d53ac241a11ca962572816283a0c653fcde9f9e
Gerrit-Change-Number: 42242
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 Jul 2020 21:53:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Tim Chu
Tim.Chu@quantatw.com
Gerrit-MessageType: comment