Attention is currently required from: Iru Cai (vimacs).
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41473 )
Change subject: inteltool: Support dumping IOBP register values
......................................................................
Patch Set 18:
(1 comment)
File util/inteltool/iobp.c:
https://review.coreboot.org/c/coreboot/+/41473/comment/f1c1629b_8fa44989
PS17, Line 74: typedef struct {
: u32 addr;
: char *name;
: } iobp_register_t;
Not needed, but the following array definitions will have one more "struct" like "struct iobp_regist […]
https://doc.coreboot.org/contributing/coding_style.html#typedefs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41473
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f11640fdff59a5317f19057476f7e48c2956ab9
Gerrit-Change-Number: 41473
Gerrit-PatchSet: 18
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Pablo Stebler
pablo@stebler.xyz
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Comment-Date: Thu, 03 Jun 2021 12:25:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-MessageType: comment