Jeremy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37660 )
Change subject: ifwitool: Introduce a use the Second Logical Boot Partition option ......................................................................
Patch Set 5:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@9 PS2, Line 9: apololake
nit: apollolake or Apollo lake
Done
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@9 PS2, Line 9: require
allow?
Done
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@10 PS2, Line 10: usually in the ifwi binary
Isn't that optional?
yes and not. The security engine may require a second logical boot partition.
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@11 PS2, Line 11: BPDT
Do you mean IFWI?
Done
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@16 PS2, Line 16: This is useful to extract the Logical Boot Partition : 2 contains in some IFWI to inject it with fmaptool.
Just to ensure I understand this correctly. […]
The idea is to be able to extract this second Logical Boot Partition and inject it to the final image.
I was not really proud of this implementation either. I reworked/simplified, I hope you are going to like the new design better.
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@23 PS2, Line 23: BPDP
BPDT
Done
https://review.coreboot.org/c/coreboot/+/37660/2//COMMIT_MSG@23 PS2, Line 23: or third, ...
I think IFWI for APL allows only two?
Correct.
https://review.coreboot.org/c/coreboot/+/37660/2/util/cbfstool/ifwitool.c File util/cbfstool/ifwitool.c:
https://review.coreboot.org/c/coreboot/+/37660/2/util/cbfstool/ifwitool.c@18... PS2, Line 1870: f:s:vh
Why does only create support this option?
Because it was linked to the need I identified but technically you are right, it can be extended to the other options which I did and tested.