Attention is currently required from: Michał Żygowski.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59810 )
Change subject: cpu/amd/pi/Kconfig: select NO_SMM
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59810/comment/a917b861_a167e531
PS2, Line 9: Disable SMM_ASEG and select NO_SMM since we don't use SMM.
`we don't` -> `the platforms do not use SMM`
Done
https://review.coreboot.org/c/coreboot/+/59810/comment/d6c0c4b7_44ace60a
PS2, Line 11: TEST=Boot on PC Engines apu3
Boot what? Seems something is missing between "Boot" and "on"
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47237421c3dd5bd043447831263d72c9956cdaf4
Gerrit-Change-Number: 59810
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 14:15:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment