Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38800 )
Change subject: soc/intel/common: Check prerequisites for GLOBAL_RESET command ......................................................................
Patch Set 12: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... PS12, Line 611: static int cse_check_global_reset_prerequisites(void) Return a bool? Maybe rewrite the function name as a question:
static bool cse_is_global_reset_allowed(void)
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... PS12, Line 614: HMRFPO ENABLE Copypasta?
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... PS12, Line 622: cse_is_hfs1_cws_normal() This can be factored out:
if (!cse_is_hfs1_cws_normal()) return false;
if (cse_is_hfs1_com_normal()) return true;
if (cse_is_hfs3_fw_sku_custom()) { if (cse_is_hfs1_com_soft_temp_disable()) return true; if (cse_is_hfs1_com_secover_mei_msg()) return true; }
return false;
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... PS12, Line 659: is not meeting does not meet