Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41674 )
Change subject: soc/intel/common/block/sata: Fix SATA detection issue between Ports 3-7
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41674/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41674/1//COMMIT_MSG@10
PS1, Line 10: on Intel H-PCH.
Is there a bug report for that? Please elaborate why the range is increased.
Ack
https://review.coreboot.org/c/coreboot/+/41674/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/41674/1/src/soc/intel/common/block/...
PS1, Line 44: port_impl &= 0xFF; /* bit 0-7 */
I think we can remove this line now. port_impl(u8) would be 8 bit read from config space.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied3832b26ba1fdd4c30fafe8149689a01d302c3e
Gerrit-Change-Number: 41674
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 24 May 2020 08:35:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment