[coreboot-gerrit] Change in ...coreboot[master]: fit: Check all compat strings for highest match

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32874 )

Change subject: fit: Check all compat strings for highest match
......................................................................

fit: Check all compat strings for highest match

The compat string matching code was mostly copied from depthcharge. One
of the few differences is that we now store the list of compat strings
we're willing to match in a list rather than an array. Since our lists
insert at the front, that means the strings are now ordered lowest to
highest (not highest to lowest like in depthcharge).

We did rewrite the compat_rank matching code to accomodate for that...
however, what we didn't do is remove the break-statement in the loop
that matches all compat strings. When we search the lowest priority
first, we can't abort the search as soon as we found a match -- we have
to keep looking because we might find a higher priority match later.

This patch fixes the issue so that my Kevin can actually match for
google,kevin-rev5 (and doesn't just jump at the first best google,kevin
match).

Change-Id: Ibe3d84bbce6de3cd49c746a667ae1ccfdc843105
Signed-off-by: Julius Werner 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32874
Reviewed-by: Hung-Te Lin 
Tested-by: build bot (Jenkins) 
---
M src/lib/fit.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Hung-Te Lin: Looks good to me, approved

diff --git a/src/lib/fit.c b/src/lib/fit.c
index 6ac0a89..37dfc8d 100644
--- a/src/lib/fit.c
+++ b/src/lib/fit.c
@@ -463,7 +463,6 @@
    		config->compat_rank = i;
    		config->compat_string =
    			compat_node->compat_string;
-			break;
    	}
    	i++;
    }