Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43484 )
Change subject: Documentation: Revise "24 hours wait period" rules
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43484/3/Documentation/getting_start...
File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/43484/3/Documentation/getting_start...
PS3, Line 59: from the same organization, although that's not a hard requirement.
When there is no enforcement of documentation policies, the quality of commit messages becomes a maj […]
Sorry, but I don't understand what you're getting at here, at all.
An emergency fix doesn't need a design concept: It needs to be clear what problem it is fixing, it needs to be clear what impact it has on other hardware, and if it's complex
enough to need a design concept it's probably not an emergency fix.
But to be honest, "design concept" is stretching it for pretty much everything I've seen land in coreboot in the last 20 years, so it feels to me that you're shifting goal posts here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43484
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I620e48016a1ceda2ac43f26624ed21af01f6a0a5
Gerrit-Change-Number: 43484
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@scarletltd.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jul 2020 18:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment