Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40805 )
Change subject: mainboard/google/kahlee: support Realtek RTL8822CE WLAN ......................................................................
mainboard/google/kahlee: support Realtek RTL8822CE WLAN
gpio70 is assigned to use as WLAN rst in new schematic to fullful RTK RTL8822CE power sequence: WLAN rst will need to be active at least 50ms after WLAN power on.
Also in order to keep the rst low in consistency, change default gpio70 to low.
BUG=b:154357210 BRANCH=master TEST=emerge-grunt coreboot
Change-Id: I98c8afe42b7f92016f83483acbb3b9ae64b159f7 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/careena/variant.c 2 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/40805/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index 4fb60b1..e5c02d5 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -43,7 +43,7 @@ PAD_GPO(GPIO_40, LOW),
/* GPIO_70 - WLAN_PE_RST_L */ - PAD_GPO(GPIO_70, HIGH), + PAD_GPO(GPIO_70, LOW),
/* GPIO_74 - LPC_CLK0_EC_R */ PAD_NF(GPIO_74, LPCCLK0, PULL_DOWN), diff --git a/src/mainboard/google/kahlee/variants/careena/variant.c b/src/mainboard/google/kahlee/variants/careena/variant.c index d35ec48..fb71b9f 100644 --- a/src/mainboard/google/kahlee/variants/careena/variant.c +++ b/src/mainboard/google/kahlee/variants/careena/variant.c @@ -16,6 +16,8 @@ #include <ec/google/chromeec/ec.h> #include <baseboard/variants.h> #include <variant/sku.h> +#include <gpio.h> +#include <variant/gpio.h>
void variant_romstage_entry(int s3_resume) { @@ -35,4 +37,9 @@ break; } } + + /* Config WLAN RST - GPIO70 PU: release RST */ + /* From RTK RTL8822CE spec, WLAN RST needs to be active */ + /* at least 50 ms since WLAN power on */ + gpio_set(GPIO_70, 1); }