HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45751/6/src/include/acpi/acpi.h
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/6/src/include/acpi/acpi.h@44
PS6, Line 44: ACPI_DSDT_REV_2
Exactly what I was targeting originally. Thank you.
Done
https://review.coreboot.org/c/coreboot/+/45751/4/src/include/acpi/acpi.h
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/4/src/include/acpi/acpi.h@44
PS4, Line 44: CURRENT_DSDT_REV
The "current" in the name seems to imply that we might update this in the […]
Done
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44
PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
I just had a short look at ACPI specs v3.0, 4.0, 5.0 and 6.3 (current one). […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040
Gerrit-Change-Number: 45751
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 13:47:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment