Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44355 )
Change subject: soc/intel/tigerlake: Allow fine grained control of S0iX states
......................................................................
Patch Set 3:
Only now do I realize that the LpmStateEnableMask I am working with in mainboard_silicon_init_params() is actually the params struct, which already has LpmStateEnableMask, and not the config struct which I am adding a field to in this CL.
https://review.coreboot.org/c/coreboot/+/44359/4/src/mainboard/google/voltee...
This means, as far as I can tell, that this CL is unnecessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a0cf820e20961486813067c6945fe07bc4899f7
Gerrit-Change-Number: 44355
Gerrit-PatchSet: 3
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 13 Aug 2020 19:12:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment